-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for positional args in graphql/execute/subscribe func #2301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: It's a big breaking change and is intended to be released only in v16.x.x line
IvanGoncharov
added
the
PR: breaking change 💥
implementation requires increase of "major" version number
label
Dec 20, 2019
IvanGoncharov
added a commit
that referenced
this pull request
Sep 3, 2020
IvanGoncharov
added a commit
that referenced
this pull request
Oct 9, 2020
IvanGoncharov
added a commit
that referenced
this pull request
Oct 20, 2020
IvanGoncharov
added a commit
that referenced
this pull request
Dec 8, 2020
kamilkisiela
pushed a commit
to kamilkisiela/graphql-js
that referenced
this pull request
Dec 29, 2020
IvanGoncharov
added a commit
that referenced
this pull request
Jan 9, 2021
IvanGoncharov
added a commit
that referenced
this pull request
Jan 11, 2021
IvanGoncharov
added a commit
that referenced
this pull request
Jan 15, 2021
IvanGoncharov
added a commit
that referenced
this pull request
Jan 20, 2021
kamilkisiela
pushed a commit
to kamilkisiela/graphql-js
that referenced
this pull request
Jan 22, 2021
IvanGoncharov
added a commit
that referenced
this pull request
Jan 22, 2021
kamilkisiela
pushed a commit
to kamilkisiela/graphql-js
that referenced
this pull request
Jan 26, 2021
IvanGoncharov
added a commit
that referenced
this pull request
Jan 27, 2021
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Jan 31, 2021
IvanGoncharov
added a commit
that referenced
this pull request
Feb 1, 2021
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Feb 20, 2021
Can you please update a note about this change? For the apollo server subscriptions, this is a required dependencies. Is there any solution for overriding this |
@riginoommen I don’t think Apollo supports v16 yet they are working on it apollographql/apollo-server#5857 this is something they need to update in docs nothing we can do here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: It's a big breaking change and is intended to be released only in v16.x.x line