Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incremental: always only emit single completion error for deferred fragment #4092

Closed
wants to merge 1 commit into from

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented May 16, 2024

When multiple deferred grouped field sets within a fragment error causing the fragment to complete in error, only a single completion error should be emitted.

@yaacovCR yaacovCR requested a review from robrichard May 16, 2024 03:14
@yaacovCR yaacovCR added the PR: bug fix 🐞 requires increase of "patch" version number label May 16, 2024
Copy link

netlify bot commented May 16, 2024

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 0e8830e
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/66457a2c6ff14b00084ab638
😎 Deploy Preview https://deploy-preview-4092--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR changed the title add fix for multiple deferred grouped field sets failing incremental: emit single error for fragment when multiple deferred grouped field sets fail May 16, 2024
@yaacovCR yaacovCR changed the title incremental: emit single error for fragment when multiple deferred grouped field sets fail incremental: always only emit single completion error for deferred fragment May 16, 2024
@yaacovCR
Copy link
Contributor Author

Fix for this, and the corresponding test has been integrated into #4094

@yaacovCR yaacovCR closed this May 30, 2024
@yaacovCR yaacovCR deleted the fix-bugs branch September 5, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant