Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish(incremental): remove id mutation #4107

Closed
wants to merge 1 commit into from

Conversation

yaacovCR
Copy link
Contributor

depends on #4106

Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 68fa5ab
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/66731759a13aad0008de1ae7
😎 Deploy Preview https://deploy-preview-4107--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yaacovCR yaacovCR added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Jun 14, 2024
@yaacovCR yaacovCR requested a review from robrichard June 14, 2024 10:44
Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR
Copy link
Contributor Author

As discussed with @robrichard offline, will drop this in favor of assigning ids sequentially during execution, even though if early execution is enabled, this means that ids might be delivered out of order or even never sent (when results are filtered). Will submit that in a separate PR.

@yaacovCR yaacovCR closed this Jun 19, 2024
@yaacovCR yaacovCR deleted the use-map branch September 5, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants