This repository has been archived by the owner on Sep 2, 2020. It is now read-only.
Switch to peerDependencies for graphql and add 0.11 #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay I did not want to fix so much, but it seemed the flow config was wrong and after fixing it flow revealed a real problem in graphql-language-service, so I fixed this too. |
|
Thanks for your contribution @danez! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem with the latest GraphiQL that it uses two different versions of graphql, because the packages from this repository still rely on graphql 0.11.
I thought the best solution is to go with peer dependencies as codemirror-graphql has a peer dependency on graphql anyway.
Also removed the top-level dev-dependencies on the
graphql-language-service-*as yarn creates them anyway.