Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to TypeScript #340

Merged
merged 4 commits into from
Dec 14, 2021
Merged

Migrate to TypeScript #340

merged 4 commits into from
Dec 14, 2021

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Jun 18, 2021 •
edited
Loading

  • Enable strict mode
  • compare .d.ts and remove them
  • Use tsc to generate .d.ts
  • use npm@7 to install stuff

@codecov
Copy link

codecov bot commented Jun 18, 2021 •
edited
Loading

Codecov Report

Merging #340 (661214a) into main (06633c3) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 661214a differs from pull request most recent head 266ecf0. Consider uploading reports for the commit 266ecf0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main      #340   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          746       746           
  Branches        51        51           
=========================================
  Hits           746       746
Impacted Files Coverage Δ
src/__testUtils__/__tests__/dedent-test.ts 100.00% <ø> (ø)
src/__testUtils__/dedent.ts 100.00% <ø> (ø)
src/__tests__/starWarsConnection-test.ts 100.00% <ø> (ø)
src/__tests__/starWarsMutation-test.ts 100.00% <ø> (ø)
src/__tests__/starWarsObjectIdentification-test.ts 100.00% <ø> (ø)
src/__tests__/starWarsSchema.ts 100.00% <ø> (ø)
src/connection/__tests__/arrayConnection-test.ts 100.00% <ø> (ø)
src/connection/__tests__/connection-test.ts 100.00% <ø> (ø)
src/connection/arrayConnection.ts 100.00% <ø> (ø)
src/connection/connection.ts 100.00% <ø> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06633c3...266ecf0. Read the comment docs.

IvanGoncharov
IvanGoncharov reviewed Jun 28, 2021
View reviewed changes
src/node/plural.ts Outdated Show resolved Hide resolved
@saihaj saihaj force-pushed the migrate-ts branch 3 times, most recently from 8fcda88 to c1a1fcc Compare June 30, 2021 03:21
IvanGoncharov
IvanGoncharov reviewed Jul 7, 2021
View reviewed changes
.eslintrc.yml Outdated Show resolved Hide resolved
@saihaj saihaj force-pushed the migrate-ts branch 4 times, most recently from 28c1ad4 to 9b98bda Compare July 10, 2021 03:31
@saihaj saihaj marked this pull request as ready for review July 10, 2021 05:33
This was referenced Aug 1, 2021
Closed
Merged
Merged
IvanGoncharov added a commit to IvanGoncharov/graphql-relay-js that referenced this pull request Dec 7, 2021
@IvanGoncharov
Improve internal typings
3af3862 
Extracted from graphql#340
@IvanGoncharov IvanGoncharov mentioned this pull request Dec 7, 2021
Merged
@IvanGoncharov IvanGoncharov force-pushed the migrate-ts branch 7 times, most recently from acbbc08 to 88a7a3f Compare December 8, 2021 16:27
@IvanGoncharov IvanGoncharov mentioned this pull request Dec 8, 2021
Merged
@saihaj @IvanGoncharov
convert js to ts
a732408 
`find src -name "*.js" -exec sh -c 'git mv "$0" "${0%.js}.ts"' {} \;`
@IvanGoncharov IvanGoncharov merged commit 08a4a87 into graphql:main Dec 14, 2021
@IvanGoncharov IvanGoncharov added the PR: breaking change 💥 implementation requires increase of "major" version number label Dec 14, 2021
@saihaj saihaj deleted the migrate-ts branch December 14, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanGoncharov IvanGoncharov IvanGoncharov left review comments

Assignees
No one assigned
Labels
PR: breaking change 💥 implementation requires increase of "major" version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saihaj @IvanGoncharov