Clarify Ruru's relation to GraphiQL #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
enisdenjo
reviewed
May 15, 2024
| To do so, install the `ruru` module with `npm install --save ruru` and then add the following to your `server.js` file, then restart the `node server.js` command: | ||
|
|
||
| ```js | ||
| var { ruruHTML } = require("ruru/server") |
There was a problem hiding this comment.
It's copied from your previous code; but I thought exactly the same thing. (I personally never use var and very rarely use let.)
There was a problem hiding this comment.
Ah I prolly did the same, copied from the last code haha. We can make a follow-up PR changing all vars to consts where applicable.
enisdenjo
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1625
Description
A reworking of the graphql-http/Express documentation to separate GraphiQL into its own section and clarify the relation to Ruru.