Release 1.2.1 #41
Merged
Release 1.2.1 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnal visibility to our rust and python dependencies
…them both will work, but we'll see. I'm also afraid it's going to only look for Cargo lock files, not the source toml files themselves.
…nction, so I can always do my work there and know it's valid yaml first
There's a [CVE](https://nvd.nist.gov/vuln/detail/CVE-2020-26235) out for the `time` crate, which `chrono` depends on. Our last build was so long ago that it was built using a version of `time` that had this issue. In theory, merely making a new build will rectify this. In theory.
Maturin no longer builds sdists by default and has dropped support for --no-sdist
Build with New Deps
* Update metadata to include Python 3.11 * Add 3.11 to README
* Build package with maturin 1.4.0 * Loosen maturin version requirement * Remove pyo3 from install instructions in README * Remove empty package.metadata.maturin section * Fix the builds * Update action versions * Lock maturin to major version * Bump version of python package to 1.2.1 * Add building src-dist in ubuntu build * Update build.yml Writing out the sha256 checksum for the sdist in `dist/` * Update README.md We should probably support 3.12 as well, since it's a final release. It *should* work, since we're specifically only targeting the broader python 3 abi with this. I should write some simple unit tests that run across the full matrix of python versions. That's a fix for me to do, though. * Update pyproject.toml 3.12 support! We think! --------- Co-authored-by: Dax Pryce <daxpryce@microsoft.com>
* Update build.yml * Update build.yml upload/download artifacts @ v2 behaved differently than @ v4. This should fix them, in theory.
I had set it to download the windows dist artifact twice and the macOS dist artifact got skipped.
bryantower
reviewed
Jan 23, 2024
bryantower
reviewed
Jan 24, 2024
bryantower
previously approved these changes
Jan 25, 2024
We're technically supporting the entire python3 abi, not just specific versions
We don't use this anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releasing 1.2.1 by incrementing some maturin build actions and versions.
This is necessary to support the conda build for graspologic: graspologic-org/graspologic#822