Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

promote Teams to first-class citizenship #3400

Closed
wants to merge 19 commits into from
Closed

promote Teams to first-class citizenship #3400

wants to merge 19 commits into from

Conversation

chadwhitacre
Copy link
Contributor

This will be at least part of #3399.

@chadwhitacre chadwhitacre added this to the Pivot milestone May 11, 2015
@chadwhitacre chadwhitacre changed the title promote Teams to a first-class citizen on Gratipay promote Teams to first-class citizenship May 11, 2015
@chadwhitacre
Copy link
Contributor Author

We don't need pledging any longer, which means we can cut out almost all of the simplates under /on/%platform/. I guess it's still useful to redirect from there to a connected Gratipay account.

@chadwhitacre
Copy link
Contributor Author

Let's call this PR done when all the UI for modifying tips and takes is converted into UI for modifying subscriptions and payroll.

  • move "your tip" widget on profile/elsewhere to "your payment" widget on team
  • move /~$username/members/ to /$team/payroll/
  • compute things on team (receiving, nsupporters, payroll, npayroll)

@chadwhitacre chadwhitacre mentioned this pull request May 11, 2015
Closed
@chadwhitacre
Copy link
Contributor Author

71 failed, 469 passed, 7 xfailed in 60.76 seconds

My goal for the evening is to get these tests cleaned up. Then I might turn the Teams explore page off to try to bring this to a mergeable state.

@chadwhitacre
Copy link
Contributor Author

As a way to fix the test suite, I'm looking at fixing the new Team class to work against the old takes table. Once that's working I'll migrate it to the payroll table.

@chadwhitacre
Copy link
Contributor Author

Bah. That's foolish. The takes table references participants, not teams.

@chadwhitacre
Copy link
Contributor Author

58 failed, 472 passed, 7 xfailed in 64.18 seconds

@chadwhitacre
First pass at schema for next-gen Teams
bea8481
@chadwhitacre
Move /$username/ to /~$username/
4f4a99a 
This makes way for /$teamname/. I'll address the redirects back and
forth between participants and teams in another commit.
@chadwhitacre
Here's a regression in username canonicalization
43a2dfe
@chadwhitacre
Fix regression with ~Username canonicalization
d630b3c
@chadwhitacre
Made a Team model, minimally loadable by fake_data
7505e6e
@chadwhitacre
New teams listing and profile minimally working
f8e308a
@chadwhitacre
test_teams is passing
32d3080
@chadwhitacre
Unit tests for Participant.set_tip_to are passing
6163ddf
@chadwhitacre
Clean up some more tests. This is a lot of work.
3118528
@chadwhitacre
Rip out goal
847916f 
No longer really sensible for individuals, and we should do a better
implementation for teams (Kickstarter/Patreon "at this level we'll be
able to ...").
@chadwhitacre
Rip your tip out of sidebar on profile/elsewhere
cd50dff
@chadwhitacre
Copy link
Contributor Author

Rebased on master after #3389.

@chadwhitacre
Rename make data to make fake
d6372ed 
We introduced a `data` directory in #3329, which masks our phony target
for populating the database with fake data.
@chadwhitacre
It ain't pretty. I'm not sayin' it's pretty.
7715a8d 
But I can save tips to teams from the UI now.
@chadwhitacre
Populate teams more in fake data
5a284d3
@chadwhitacre
Rough over payroll from old members page
0869349
@chadwhitacre
Copy link
Contributor Author

143 failed, 370 passed Ouch

@chadwhitacre
Copy link
Contributor Author

My God, it's full of 🐛s!

xl1xyq8

@chadwhitacre chadwhitacre mentioned this pull request May 12, 2015
Closed
@chadwhitacre chadwhitacre mentioned this pull request May 12, 2015
Closed
@rohitpaulk rohitpaulk mentioned this pull request May 12, 2015
Closed
@chadwhitacre
Fix get_teams to return Team instances
2ede954
@chadwhitacre
Fix nmembers computed property on Team
f939667 
Really we want to drop this in favor of a cached value in the db.
@chadwhitacre
Kill tips.json
839f991 
I think we should remove this API endpoint and add a new one once Teams
settle a bit.
@chadwhitacre
Kill claimed tips
c11c232
chadwhitacre added a commit that referenced this pull request May 12, 2015
@chadwhitacre
Fix up a few tests
b6e946c 
These were added on master after I made the commits that I cherry-picked
from #3400.
This was referenced May 12, 2015
Merged
Merged
@chadwhitacre
Copy link
Contributor Author

I ended up scavenging this for parts. See #3399 for details.

@chadwhitacre chadwhitacre mentioned this pull request May 13, 2015
Merged
@chadwhitacre chadwhitacre deleted the first-class-teams branch May 13, 2015 11:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Pivot
Development

Successfully merging this pull request may close these issues.
1 participant
@chadwhitacre