-
Notifications
You must be signed in to change notification settings - Fork 29
feat(YfmTable): rework table controls – add drag-n-drop, rows and columns insertion #831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview is ready. |
Visual Tests Report is ready. |
0362a36
to
2bd5239
Compare
When you click and slightly move the mouse, the button flickers because a drag event starts, even though it was essentially an imprecise click (a click with a slight movement). I suggest adding a threshold to check that the movement was minimal, and if the movement is small, it shouldn’t be considered a drag (a drag start threshold). |
...YfmTable-should-add-column-via-click-on-floating-plus-button-wysiwyg-dark-chromium-linux.png
Show resolved
Hide resolved
* | ||
* @default true | ||
*/ | ||
controls?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously, there were controls in the mobile version as well, but now they are only in the full version.
I suggest we think about how the controls should work in the mobile version.
70c5518
to
06d2f0b
Compare
2ec39d5
to
21bf4c9
Compare
Uh oh!
There was an error while loading. Please reload this page.