Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How's the mobile support and the suggestion #2

Open
Tokenyet opened this issue May 20, 2021 · 7 comments
Open

How's the mobile support and the suggestion #2

Tokenyet opened this issue May 20, 2021 · 7 comments
Assignees
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@Tokenyet
Copy link

Tokenyet commented May 20, 2021

At first glance, the source code is based on keppelen/react-facebook-login. And there is a big unsolved issue on Mobile, especially newer iOS safari.

The more interesting is that you remove the isMobile and disableMobileRedirect in this package.

That comes the question, how did you slove It?

I think this is the most interesting thing that encourage others to use this package, and you might want to add in Readme 😄

By the way, I didn't use official version, because the bad typescript support, I need to use the fork version to get render. Hope this package could replace successfully 👍

@Tokenyet Tokenyet changed the title Some unique question about this pacakge The feature and the suggestion May 20, 2021
@Tokenyet Tokenyet changed the title The feature and the suggestion How's the mobile support and the suggestion May 20, 2021
@greatSumini greatSumini added the question Further information is requested label Jun 6, 2021
@greatSumini
Copy link
Owner

Didn't catch that issue.. I will try to solve it!
thank u for interest! 😃

@greatSumini greatSumini self-assigned this Jul 16, 2021
@greatSumini greatSumini pinned this issue Jul 17, 2021
@greatSumini greatSumini added the help wanted Extra attention is needed label May 5, 2022
@mifi
Copy link

mifi commented Aug 19, 2022

I just tested on iOS and it's working with tihs package.

By the way, I didn't use official version, because the bad typescript support, I need to use the fork version to get render. Hope this package could replace successfully 👍

this package also supports render.

@cgarrovillo
Copy link

Any updates on this? Still broken for in-app browsers which is what the original issue states.

@greatSumini
Copy link
Owner

greatSumini commented Feb 15, 2023

@cgarrovillo

i just released v3.3.2, including suggested solution in original issue
can u try it?

@cgarrovillo
Copy link

I think additional documentation is now needed, since the onSuccess and onFail functions are not applicable anymore when using useRedirect

@aviram120
Copy link

Hi
for my - the fb login in Facebook bowser didn't work.

this is my config:

              { <FacebookLogin
                            appId={config.FACEBOOK_LOGIN_CLIENTID}
                            autoLoad={false}
                            useRedirect={true}
                            fields="name,email,picture"
                            onProfileSuccess ={componentClicked}
                            onSuccess={responseFacebook} 
                            onFail={handleFailureSignup}
                            style={{
                                backgroundColor: '#4267b2',
                                color: '#fff',
                                fontSize: '16px',
                                padding: '12px 24px',
                                border: 'none',
                                borderRadius: '4px',
                              }}
                        /> } 

any advice how to solved it?
@greatSumini

@timothylui
Copy link

It doesn't work for me either. In the desktop browser, it opens a pop-up to perform the login, if it tries to do the same in an embedded browser it will fail, which is what I think is happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

6 participants