Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allow creating releases without having git changes #752

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Apr 27, 2023

What

Allow creating releases without having git changes

Why

Only try to create a new git commit if there are actual changes like project version file updates. This allows to create a release even if there aren't any git changes during the release process.

References

https://github.com/greenbone/actions/actions/runs/4820509528/jobs/8585091300

DEVOPS-652

Checklist

  • Tests

@bjoernricks bjoernricks marked this pull request as ready for review April 27, 2023 14:39
@bjoernricks bjoernricks requested a review from a team as a code owner April 27, 2023 14:39
@bjoernricks bjoernricks enabled auto-merge (rebase) April 27, 2023 14:40
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@7090d11). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head acb4dd2 differs from pull request most recent head 25555a3. Consider uploading reports for the commit 25555a3 to get more accurate results

@@           Coverage Diff           @@
##             main     #752   +/-   ##
=======================================
  Coverage        ?   89.73%           
=======================================
  Files           ?       81           
  Lines           ?     5269           
  Branches        ?      741           
=======================================
  Hits            ?     4728           
  Misses          ?      381           
  Partials        ?      160           
Impacted Files Coverage Δ
pontos/release/release.py 96.55% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@y0urself y0urself force-pushed the release-without-git-changes branch from dd1170c to acb4dd2 Compare April 28, 2023 07:15
Only try to create a new git commit if there are actual changes like
project version file updates. This allows to create a release even if
there aren't any git changes during the release process.
@y0urself y0urself force-pushed the release-without-git-changes branch from acb4dd2 to 25555a3 Compare April 28, 2023 07:17
@bjoernricks bjoernricks merged commit 98ba594 into main Apr 28, 2023
@bjoernricks bjoernricks deleted the release-without-git-changes branch April 28, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants