Fix: Allow creating releases without having git changes (2) #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also only try to create a new git commit if there are actual changes like project version file updates after a release. This avoids failing releases even when the GitHub release has been created and pushed already.
Codecov Report
@@ Coverage Diff @@
## main #753 +/- ##
=======================================
Coverage 89.73% 89.74%
=======================================
Files 81 81
Lines 5272 5275 +3
Branches 741 742 +1
=======================================
+ Hits 4731 4734 +3
Misses 381 381
Partials 160 160
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
y0urself
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allow creating releases without having git changes part 2
Why
Also only try to create a new git commit if there are actual changes like project version file updates after a release. This avoids failing releases even when the GitHub release has been created and pushed already.
References
https://github.com/greenbone/actions/actions/runs/4828176908/jobs/8601688904
Checklist