Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PanCanAtlas Data Download #75

Merged
merged 9 commits into from
Apr 18, 2018
Merged

Conversation

gwaybio
Copy link
Collaborator

@gwaybio gwaybio commented Apr 18, 2018

Adding instructions to download raw, versioned data. These raw files are not tracked, but the processed datasets used in Way et al. 2018 are added here.

@gwaybio gwaybio requested a review from dhimmel April 18, 2018 16:35
README.md Outdated
# Create and activate conda environment
conda env create --quiet --force --file environment.yml
source activate pancancer-classifier
git clone git@github.com:greenelab/pancancer.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this sufficient to get the data from git-lfs?

Copy link

@dhimmel dhimmel Apr 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe if the user has Git LFS installed, this command will download LFS assets... probably worth testing, and perhaps mentioning in README to make sure to have git-lfs installed. Alternatively you can add https://anaconda.org/conda-forge/git-lfs to the environment. (clone comes before env install, so that doesn't make sense)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think that is how it would work too. I will add that note here as well

@gwaybio gwaybio merged commit 0431543 into greenelab:master Apr 18, 2018
@gwaybio gwaybio deleted the add-data-download branch April 18, 2018 17:35
This was referenced Apr 18, 2018
@gwaybio gwaybio mentioned this pull request May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants