Ramenhog/version url param #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
This is perfect for my needs!! |
dongbohu
reviewed
Apr 17, 2018
interface/src/app/genesets/use.js
Outdated
| $scope.chosenVersion = Versions.get(verParams); | ||
| $location.search({ version: chosenVersionHash }); | ||
| }; | ||
| $scope.geneset.$promise.then(function(data) { |
There was a problem hiding this comment.
You may want to add a blank line between 280 and 281 to make it more readable.
interface/src/app/genesets/use.js
Outdated
| var versionParam = $location.search().version; | ||
|
|
||
| if (versionParam) { | ||
| var matchingVersions = $scope.geneset.versions.filter(function( |
There was a problem hiding this comment.
The search of versionParam doesn't have to scan the whole $scope.geneset.versions. It will be done when one match is found. So it can be written like this:
if (versionParam) {
var found = $scope.geneset.versions.find(function(version) {
return version.ver_hash === versionParam;
});
if (found) {
initialVersion = versionParam;
}
}
...
Of course, if $scope.geneset.versions includes only a few elements, then no big deal.
| @@ -12,354 +12,409 @@ | |||
| * The dependencies block here is also where component dependencies should be | |||
| * specified, as shown below. | |||
| */ | |||
| angular.module( 'tribe.genesets.use', [ | |||
There was a problem hiding this comment.
Did you change anything else except the coding style in this file?
There was a problem hiding this comment.
Never mind, I meant the other parts except showVersion().
|
Thanks, just addressed the concerns. Back to you :) @dongbohu |
dongbohu
approved these changes
Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13
The main changes to
use.jsare in theshowVersion()function on line #271. The file was also reformatted with JSPrettier.