Replace "option_list" with "parser.add_argument" #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
dhimmel
approved these changes
Feb 19, 2019
| print('Geneset ' + str(toks[int(geneset_column)]) + '-' + | ||
| str(gs_name) + ' and organism ' + str(org) + | ||
| ' does not exist in our database' | ||
| ) |
There was a problem hiding this comment.
String formatting rather than concatenation would improve readability. What is the min python version required here?
There was a problem hiding this comment.
It should be fair to say Python 2.7. These management commands are only used in the tests right now, so I didn't spend too much time improving them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #39 with the following extra revisions:
genesets/tests.py:ResourceTestCaseclass is replaced byResourceTestCaseMixin, because the former has been deprecated.genesets_update_tip_item_count_all.pyis removed because it is not being used anywhere.Changes have been tested by the relevant unit tests.