Setup static analysis with Psalm #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
sa-with-psalm
branch
3 times, most recently
from
7bcc967
to
8cce3ab
Compare
This should make it easier to work with Composer from machines using different versions of PHP than the lowest one we use in the CI.
greg0ire
force-pushed
the
sa-with-psalm
branch
2 times, most recently
from
b3f71e0
to
6370f83
Compare
greg0ire
pushed a commit
that referenced
this pull request
Apr 14, 2020
The new version contains some improvements in handling mocks (sebastianbergmann/phpunit#3602) and will help identify some existing issues in DBAL 3.0 tests: There were 2 warnings: 1) Doctrine\Tests\DBAL\Driver\OCI8\OCI8StatementTest::testExecute with data set #0 (array('test', null, 'value')) Method bindValue may not return value of type boolean 2) Doctrine\Tests\DBAL\Driver\OCI8\OCI8StatementTest::testExecute with data set #1 (array(null, 'test', 'value')) Method bindValue may not return value of type boolean
greg0ire
pushed a commit
that referenced
this pull request
Jan 29, 2024
<!-- Fill in the relevant information below to help triage your pull request. --> | Q | A |------------- | ----------- | Type | bug | Fixed issues | doctrine#6038 #### Summary As described in the mentioned issue, `-0.5` from `-1 / 2` will raise type error when trying to `setLength` ``` Argument #1 ($length) must be of type ?int, float given ``` https://github.com/doctrine/dbal/blob/8bc0d9ae42f20af54120396ef7a1b3248479c2b5/src/Schema/Column.php#L78 This PR check if length is `-1` and keep it as is before perform division.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.