Skip to content

Conversation

dgrad
Copy link
Contributor

@dgrad dgrad commented May 5, 2015

No description provided.

@gregjacobs
Copy link
Owner

Cool, will check it out. Seem to remember there was some problem with single letter schemes in the past, but can't remember what that might have been.

Quick question since I'm not at a desktop right now: did you add a test or two to cover the change?

@dgrad
Copy link
Contributor Author

dgrad commented May 5, 2015

I did now

@dgrad
Copy link
Contributor Author

dgrad commented Jun 3, 2015

updated pull request based on your latest README additions about contributing

@gregjacobs
Copy link
Owner

Um, I should have merged this decades ago... Sorry!!!!!

Thanks though man, great job.

gregjacobs added a commit that referenced this pull request Oct 18, 2015
Allow single-letter schemes (fixes #100)
@gregjacobs gregjacobs merged commit 94b824d into gregjacobs:master Oct 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants