Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two issues in lsusb-t.c #173

Closed
wants to merge 0 commits into from
Closed

Conversation

naruto-abc
Copy link
Contributor

One is a potential buffer overflow issue. Another one is to show that more speeds are supported in comments.

Both of two commits are quite easy and straightforward to understand.

Copy link
Owner

@gregkh gregkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "\n" is in the original file in sysfs, which is what this comment is saying. So changing this to only \0 is not correct :(

Copy link
Owner

@gregkh gregkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't an overflow as the kernel does not make the buffer bigger.

So this is an ok change, but perhaps clean up the changelog text?

Also, please properly wrap your changelog comments at 72 columns like your
editor asks you to :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants