Force consistency with table metadata between array and object data #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielliwerant
added
v3
|
Added manually to v3. |
|
Actually, upon further testing, this update destroys performance with larger data sets. I'm going to leave this inconsistency in the table for now until a better performing work around can be developed. |
patorjk
added
investigate further
on hold
and removed
v3
This was referenced Jul 11, 2020
Merged
|
Issue resolved in #1404 (new tableMeta parameter currentTableData should be used). |
1 task
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #928.
Sending in array of arrays data vs array of objects data into the table was resulting in different
tableDatain thetableMetaobject. Now, either should result in data that matches passing in array of arraystableData.It's possible this will be cause breakage for people relying on the inconsistent behavior, so saving this for a major release, unless I can trace it back as a relatively new issue, at which point, it could be released with a minor release.