Skip to content

1-ci-config #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 8, 2019
Merged

1-ci-config #2

merged 14 commits into from
Feb 8, 2019

Conversation

gregswindle
Copy link
Owner

@gregswindle gregswindle commented Feb 5, 2019 •
edited
Loading

git Pull Request Pull Request (PR)

  • Configure repo for status checks.
  • Set-up automatic dependabot merges.

Associated issue(s)

Closes #1

  • 1. The acceptance criteria for all associated issues have been
    completed, tested, and validated.
  • 2. The README either reflects my changes or does not require updates.
  • 3. The CONTRIBUTING document either reflects my changes or does not
    require updates.

Code quality summary

Measure Scores
Quality gate Sonar Alert Status Metrics
Duplications Sonar Duplicated Lines Density Metrics
Maintainability Sonar Code Smells Metrics
Sonar Sqale Rating Metrics
Sonar Sqale Index Metrics
Sonar Ncloc Metrics
Reliability Sonar Reliability Rating Metrics
Sonar Bugs Metrics
Security Sonar Security Rating Metrics
Sonar Vulnerabilities Metrics
Test coverage Sonar Coverage Metrics

Code quality, vulnerability, and standards compliance tools

Code Style Linters Test frameworks
JavaScript Style Guide ESLint Jest BDD
Standard JS user guide link-external ESlint user guide link-external Jest user guide link-external

How to format, lint, and test your changes

Open a Terminal, go to the root directory for parse-numeric,
and run:

$ npm test

info Completed tasks are not required to open a PR, and may
be addressed while the PR is open.

alert All tasks must be completed and verified
before a PR may be merged into master, however.

Swindle, Gregory Jay (Greg) and others added 8 commits February 5, 2019 03:05
ci(config): configure ci services
f4a3944 
#1
ci(travis): remove node v4
508a771 
Remove Node.js engines below 6.0.0.

#1
ci(travis): disable fossa
c2a7253 
#1
ci(quality): add codacy
498b882
ci(build): add appveyor
3346b18 
- Test on Windows
- Add codacy-coverage as a dev-dependency
- Update README.md

#1
@gregswindle
ci(qa): add codeclimate
d00566d 
- Enable test coverage metrics
- Add a config file
ci(windows): configure appveyor
e2681bf 
Install-test using the same Node.js versions that Travis.ci uses.

#1
Merge branch '1-ci-config' of https://github.com/gregswindle/parse-nu…
83fd0b7 
…meric into 1-ci-config
@gregswindle gregswindle self-assigned this Feb 6, 2019
Swindle, Gregory Jay (Greg) added 3 commits February 6, 2019 17:40
ci(codeclimate): report tests by os
6993e99 
Conditionally install cc-test-reporter by os.
Still might not work, since the test reports probably
need to be merged. 🤞

#1
ci(codeclimate): no-eslint-plugin-unicorn
ec646ca 
CodeClimate does not support eslint-plugin-unicorn.
CodeClimate does, however, support eslint-config-xo, which
includes eslint-plugin-unicorn.

Replaced plugin with eslint-config-xo, and disabled
rules that do not comply with JavaScript Standard Style.

#1
@gregswindle
refactor(tests): extract function(s)
5c2566f 
Moved statements with common behaviors into helper
functions in order to comply with max-nested max-line
rules.

#1
qlty-cloud-legacy[bot]
qlty-cloud-legacy bot reviewed Feb 7, 2019
View reviewed changes
Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 8805 lines exceeds the maximum allowed for the inline comments feature.

@qlty-cloud-legacy
Copy link

There are too many results to compare

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 100.0%.

View more on Code Climate.

Repository owner deleted a comment Feb 7, 2019
Repository owner deleted a comment Feb 7, 2019
@gregswindle
refactor(ci): extract ci-services to function
516680d 
- Move legal scan initialization into .github/ci/legal/fossa-init.sh
- Move code quality scans into .github/ci/qa/code-climate-init.sh

#1
@gregswindle
ci(lint): remove shellcheck
8c52d2e 
The npm package shellcheck breaks all macOS, linux, and windows
builds. Removing it (for now).

#1
@gregswindle
Copy link
Owner Author

There are too many results to compare

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 100.0%.

View more on Code Climate.

Marked as "approved" on the CodeClimate site.

@gregswindle gregswindle closed this Feb 7, 2019
@gregswindle
Copy link
Owner Author

I didn't mean to close the PR! (I was thinking in terms of GitLab Discussion Resolution 🤦‍♂️ .)

@gregswindle gregswindle reopened this Feb 7, 2019
@gregswindle
ci(code-climate): edit config
72a95a5 
- Install to the TRAVIS_BUILD_DIR
- Run from the TRAVIS_BUILD_DIR
- Try to exit 0 on failure.

This is my last attempt to use cc-test-reporter before
I uninstall it.

#1
qlty-cloud-legacy[bot]
qlty-cloud-legacy bot reviewed Feb 7, 2019
View reviewed changes
Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 9958 lines exceeds the maximum allowed for the inline comments feature.

@gregswindle gregswindle added type: ci Changes to continuous integration and release workflow. Semver bump: PATCH (x.y.⇧) type: build Changes that affect the build system or external dependencies. Semver bump: PATCH (x.y.⇧) type: feature Adds or enhances valuable behavior. Semver bump: MINOR (x.⇧.z) type: docs Changes documentation, e.g., specifications, instructions. Semver bump: PATCH (x.y.⇧) labels Feb 8, 2019
@gregswindle gregswindle merged commit adf3246 into master Feb 8, 2019
@gregswindle gregswindle deleted the 1-ci-config branch February 8, 2019 01:10
Repository owner deleted a comment Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@qlty-cloud-legacy qlty-cloud-legacy[bot] qlty-cloud-legacy[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@gregswindle gregswindle

Labels
type: build Changes that affect the build system or external dependencies. Semver bump: PATCH (x.y.⇧) type: ci Changes to continuous integration and release workflow. Semver bump: PATCH (x.y.⇧) type: docs Changes documentation, e.g., specifications, instructions. Semver bump: PATCH (x.y.⇧) type: feature Adds or enhances valuable behavior. Semver bump: MINOR (x.⇧.z)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci(config): set-up CI/CD services
1 participant
@gregswindle