General polytope implementation #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1006 +/- ##
==========================================
+ Coverage 88.18% 88.26% +0.08%
==========================================
Files 176 177 +1
Lines 22055 22425 +370
==========================================
+ Hits 19449 19794 +345
- Misses 2606 2631 +25 ☔ View full report in Codecov by Sentry. |
|
@pmartorell can you replace GraphPolytope by GeneralPolytope? |
|
@santiagobadia I have changed the name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@santiagobadia
This PR includes the implementation of general polytopes in Gridap.
These polytopes are named
GeneralPolytope<:Polyhedron. Here,PolygonandPolyhedronare aliases ofGeneralPolytopein 2 and 3 dimensions, respectively.We note, that this implementation has been migrated from STLCutters.jl, see also gridap/STLCutters.jl#33