Define Polyhedron as GeneralPolytope<:Gridap.Polytope
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{Polygon,Polyhedron} <: GraphPolytope <: Polytope <: GridapType
pmartorell
changed the title
Polyhedron as GraphPolytope<:Gridap.PolytopePolyhedron as GeneralPolytope<:Gridap.Polytope
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
==========================================
+ Coverage 93.18% 93.28% +0.09%
==========================================
Files 5 6 +1
Lines 3627 3975 +348
==========================================
+ Hits 3380 3708 +328
- Misses 247 267 +20 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines
PolyhedronasGeneralPolytope<:Gridap.Polytope.Additionally, it moves the definition of the new
GeneralPolytopeto GridapNOTE: This PR should be merged only after releasing the changes in gridap/Gridap.jl#1006