Migrating the plugin to PostCSS 8 #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a bonus track, this will close all of the remaining pull requests from dependabot :) |
|
Hi Antonio
Thanks for your work! I‘m currently on holidays this week. Once I‘m back
I‘ll take a look and get back to you!
|
|
Antonio, thanks again for your contribution. I merged it and released version 2.0.0 🎉 |
|
@dschenk thanks! Glad it got out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
Thanks for the plugin. We use it extensively at 10up!
We've realised that the plugin contains some vulnerabilities that show up on
npm audit. I've taken the opportunity to migrate the whole plugin to PostCSS 8 trying to keep as much of how it was as possible so the change is non-invasive.Only one test had to change given that exceptions can't use numbers but regexes or strings.
I've also updated the package.json to use standard PostCSS 8 plugins support.
Please let me know if there's anything you'd have feedback on!