Fix security issue & updates dependencies #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antonio-Laguna
commented
Mar 21, 2023
| expect(e).toBeInstanceOf(TypeError) | ||
| ) | ||
| expect(() => { | ||
| return run('basic', { data: pkg, pattern: null }) |
There was a problem hiding this comment.
Changed '' by null given that the original code tests for typeof options.pattern === 'string' I'm unsure how this worked before since an empty string is actually a string after all
|
Thanks for the PR! Greatly appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @dschenk !
Hope everything is going well. I've been getting alerts when using this plugin because there is a critical security issue. I've linked it on the CHANGELOG.
I also took the chance to bump everything else as much as I could without any major hiccups except for the exception test.
Let me know if you have further questions here!