Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in add_widget with auto_position parameter of "false" #31

Closed
ishields opened this issue Dec 10, 2014 · 3 comments
Closed

Bug in add_widget with auto_position parameter of "false" #31

ishields opened this issue Dec 10, 2014 · 3 comments
Milestone

Comments

@ishields
Copy link

@troolee If you call add_widget with an auto_position parameter of false, it actually uses the auto_position mode.
Looks like its setting el.attr('data-gs-auto-position', auto_position) and when it reads it back it sets the node.auto_position = "false" as a string.
Later, this get's evaluated to true when it does the check
if (node.auto_position == true){}
if ("false" == true) which ends up going into the block.

@troolee troolee added this to the 0.2.2 milestone Dec 11, 2014
@americos
Copy link

+1

@troolee
Copy link
Member

troolee commented Dec 11, 2014

Will fix it soon

@troolee
Copy link
Member

troolee commented Dec 12, 2014

Fixed.

@troolee troolee closed this as completed Dec 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants