Skip to content

Bug fix: Init with marginTop prop or other margin props will turn height to 1 when resize a grid #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Bug fix: Init with marginTop prop or other margin props will turn height to 1 when resize a grid #1441

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b2e92c
Update gridstack.ts
deadivan Nov 5, 2020
dfa390f
Merge pull request #1 from deadivan/deadivan-patch-1
deadivan Nov 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/gridstack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1854,6 +1854,10 @@ export class GridStack {
this.opts.marginLeft = data.height;
delete this.opts.margin;
}

//without this.opts.margin, getMargin method will return undefined, and affect resize behavior
if(!this.opts.margin) this.opts.margin = Math.round((this.opts.marginTop + this.opts.marginBottom) / 2);
Copy link
Member

@adumesny adumesny Nov 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't the right fix because margin=0 is a valid value. Thanks for bringing this issue up, will fix it the proper way next...


this.opts.marginUnit = data.unit; // in case side were spelled out, use those units instead...
return this;
}
Expand Down