Skip to content

fix resize-scroll when grid is not at top of page #1727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2021
Merged

fix resize-scroll when grid is not at top of page #1727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03458c5
fix resize-scroll when gridster is not at top of page
Manfred-on-github Apr 12, 2021
da63ba5
add test case html file
Manfred-on-github Apr 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions spec/e2e/html/1727_resize_scroll_top.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1">
<link rel="stylesheet" href="../../../demo/demo.css"/>
<!-- <script src="https://cdn.jsdelivr.net/npm/gridstack@3.3.0/dist/gridstack-h5.js"></script> -->
<script src="../../../dist/gridstack-h5.js"></script>
<style>
.topHeader {
background: rgb(127, 87, 180);
height: 200px;
}
.willScroll {
height: 600px;
overflow-y: auto;
flex-grow: 1;
}
.row {
display:flex;
width: 100%;
}
.showDistance {
border-top-width: 130px;
border-bottom-width: 130px;
border-color: gray;
border-style: solid;
height: 600px;
width: 50px;
box-sizing: border-box;
}
</style>

</head>
<body>
<div class="topHeader">This is the header which brings an offset of 200 px</div>
<div class="row">
<div class="showDistance"></div>
<div class="willScroll">
<div class="grid-stack"></div>
</div>
</div>

<script type="text/javascript">
let grid = GridStack.init({cellHeight: 130});
let items = [
{x: 0, y: 0, w: 2, h: 2, content: "resize-me - check scrolling starts only when in height of gray area, and you can scroll back up as well."},
{x: 3, y: 0, w: 2, h: 2, content: "this is here to have next item positioned way down"},
{x: 3, y: 2, w: 3, h: 2, content: "resize me - scroll will start immediately, but should not be extremely fast"},
{x: 6, y: 0, w: 2, h: 8, content: "this is here to have a scroll bar from the beginning"},
];
grid.load(items);
</script>
</body>
</html>
11 changes: 6 additions & 5 deletions src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,16 +351,17 @@ export class Utils {
static updateScrollResize(event: MouseEvent, el: HTMLElement, distance: number): void {
const scrollEl = this.getScrollParent(el);
const height = scrollEl.clientHeight;

const top = event.clientY < distance;
const bottom = event.clientY > height - distance;
const offsetTop = scrollEl.getBoundingClientRect().top;
const pointerPosY = event.clientY - offsetTop;
const top = pointerPosY < distance;
const bottom = pointerPosY > height - distance;

if (top) {
// This also can be done with a timeout to keep scrolling while the mouse is
// in the scrolling zone. (will have smoother behavior)
scrollEl.scrollBy({ behavior: 'smooth', top: event.clientY - distance});
scrollEl.scrollBy({ behavior: 'smooth', top: pointerPosY - distance});
} else if (bottom) {
scrollEl.scrollBy({ behavior: 'smooth', top: distance - (height - event.clientY)});
scrollEl.scrollBy({ behavior: 'smooth', top: distance - (height - pointerPosY)});
}
}
}
Expand Down