Skip to content

fix removeable:true by itself now works #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2021
Merged

fix removeable:true by itself now works #1787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions doc/CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Change log
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
**Table of Contents** *generated with [DocToc](http://doctoc.herokuapp.com/)*

- [4.2.5-dev (TBD)](#425-dev-tbd)
- [4.2.5 (2021-5-31)](#425-2021-5-31)
- [4.2.4 (2021-5-29)](#424-2021-5-29)
- [4.2.3 (2021-5-8)](#423-2021-5-8)
Expand Down Expand Up @@ -58,6 +59,10 @@ Change log
- [v0.1.0 (2014-11-18)](#v010-2014-11-18)

<!-- END doctoc generated TOC please keep comment here to allow auto update -->
## 4.2.5-dev (TBD)

* fix [#1784](https://github.com/gridstack/gridstack.js/issues/1784) `removable:true` working by itself (without needing `acceptWidgets:true`)

## 4.2.5 (2021-5-31)

* fix for website with JQ `droppable('destroy')` giving error
Expand Down
2 changes: 1 addition & 1 deletion src/gridstack-dd.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export abstract class GridStackDD extends GridStackDDI {
GridStack.prototype._setupAcceptWidget = function(this: GridStack): GridStack {

// check if we need to disable things
if (this.opts.staticGrid || !this.opts.acceptWidgets) {
if (this.opts.staticGrid || (!this.opts.acceptWidgets && !this.opts.removable)) {
GridStackDD.get().droppable(this.el, 'destroy');
return this;
}
Expand Down