Skip to content

full grid maxRow fix #2451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2023
Merged

full grid maxRow fix #2451

merged 1 commit into from
Sep 8, 2023

Conversation

adumesny
Copy link
Member

@adumesny adumesny commented Sep 8, 2023

Description

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adumesny
full grid maxRow fix
77936c2 
* fix gridstack#2449
* move, while still being under maxRow or at least not making it worse (case where widget was somehow added past our max)
@adumesny adumesny merged commit a833269 into gridstack:master Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't shrink item when grid is full (when using max row size)
1 participant
@adumesny