Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using passive:true for mousemove events #2610

Merged
merged 1 commit into from
Jan 27, 2024
Merged

using passive:true for mousemove events #2610

merged 1 commit into from
Jan 27, 2024

Conversation

adumesny
Copy link
Member

@adumesny adumesny commented Jan 27, 2024 •
edited
Loading

Description

  • our app was showing errors calling e.preventDefault() because move events were marked as passive (which are more performant for smooth scrolling) so explicitly set it passive and skip the call.
  • verified the old issue of sweep selecting text field content isn't an issue anymore

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adumesny
using passive:true for mousemove events
1307def 
* our app was showing errors calling e.preventDefault() because move events were marked as passive (which are more performant for smooth scrolling) so explicitly  set it passive and skip the call.
* verified the old issue of sweep selecting text field content isn't an issue anymore
@adumesny adumesny merged commit 4e82e90 into gridstack:master Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@adumesny