Fix bug where removeWidget does not function properly #3159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adumesny
reviewed
Sep 17, 2025
| const removeWidget = useCallback( | ||
| (id: string) => { | ||
| gridStack?.removeWidget(id); | ||
| const element = document.body.querySelector(`[gs-id="${id}"]`); |
There was a problem hiding this comment.
const element: GridItemHTMLElement = ....
woudl be better, then no casting
|
thanks for the fix. alas the compiler doesn't catch that issue since passing a string is valid, btu looks for css selectors, not gs-id attributes (which it could I suppose as fallback). |
adumesny
added a commit
to adumesny/gridstack.js
that referenced
this pull request
Sep 22, 2025
* might be able to use GridStack.removeWidget() which now uses gs-id as last resource....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolving the issue where only the internal elements were removed when an ID was provided. Passing the element now ensures that the entire grid-stack-item-content is removed as intended.
Checklist
yarn test)