eslint support #798
Closed
eslint support #798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changing from jshint and jscs to eslint
|
Thanks, @rwstoneback ! I'll take a look at this when I have a chance and get it merged. |
|
@rwstoneback Could you resolve the conflicts? Then I'll merge it in. Thanks, though - we really appreciate the help! |
2 tasks
|
thank you @rwstoneback for that PR, I wasn't able to merge your changes but created #1041 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changing from jshint and jscs to eslint (Trying to close out #763).
Description
I believe I migrated to eslint successfully. I went through your current jslint rules and found what I thought were the equivalent for eslint. I also added it as a dependency for grunt and removed the jscs and jshint dependencies and files.
Checklist
npm test)