Add missing translations for MUI and AgGrid #714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tristan-WorkGH
force-pushed
the
intl/fix-missing
branch
2 times, most recently
from
4771577 to
043cdfc
Compare
Tristan-WorkGH
force-pushed
the
intl/fix-missing
branch
from
043cdfc to
ea57487
Compare
TheMaskedTurtle
requested changes
Apr 10, 2025
This was referenced Apr 17, 2025
TheMaskedTurtle
requested changes
Apr 17, 2025
TheMaskedTurtle
approved these changes
Apr 18, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
One specific for aggrid locales is that
https://github.com/ag-grid/ag-grid/blob/v33.1.1/community-modules/locale/src/en-US.ts#L91
To not have this unnecessary work each time the page load in the browser, this transformation is done at compile time once, and have in the build just an object per language exported like for our translations.