Enable reactor netty metrics #124
Conversation
Signed-off-by: Seddik Yengui <seddik.yengui_externe@rte-france.com>
Signed-off-by: Seddik Yengui <seddik.yengui_externe@rte-france.com>
Signed-off-by: Seddik Yengui <seddik.yengui_externe@rte-france.com>
|
|
||
| import java.util.function.Function; | ||
|
|
||
| // As discussed here https://stackoverflow.com/questions/66028195/spring-webflux-actuator-netty-thread-metrics, |
There was a problem hiding this comment.
From what I read in this, I think we should add either a template for the URI or disable the metrics that we don't use.
* It is strongly recommended to provide template-like form for the URIs. Without a conversion to a template-like form,
* each distinct URI leads to the creation of a distinct tag, which takes a lot of memory for the metrics.
from their doc.
See: https://quarkus.io/guides/telemetry-micrometer#define-tags
There was a problem hiding this comment.
you can see all the metrics it generates here: http://localhost:9000/actuator/prometheus
if you navigate a bit in the app, it generates high cardinality metrics
There was a problem hiding this comment.
I would use something like:
https://gist.github.com/antoinebhs/8907cc2f9492ce84904d020b2d800977
to only store the metrics that we really use see documentation here: https://docs.micrometer.io/micrometer/reference/concepts/meter-filters.html
It works fine on my deployment, it only adds the two metrics (that are counter so no high cardinality issue/need to template etc)
|
|
||
| import java.util.function.Function; | ||
|
|
||
| // As discussed here https://stackoverflow.com/questions/66028195/spring-webflux-actuator-netty-thread-metrics, |
There was a problem hiding this comment.
remove the link, just explain
Signed-off-by: Seddik Yengui <seddik.yengui_externe@rte-france.com>
src/main/java/org/gridsuite/gateway/NettyMetricsConfiguration.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Seddik Yengui <seddik.yengui_externe@rte-france.com>
|
As mentioned here spring-webflux-actuator-netty-thread-metrics, the metrics exposed by react-netty are not enabled by default in spring boot. To enable them, we add a custom bean