Skip to content

Conversation

Tristan-WorkGH
Copy link
Collaborator

Initial version of gridadmin with users management and connections view.

Copy link

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button Add user is not shown in the interface

Copy link
Contributor

@flomillot flomillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many commented code / TODO
Problem with routing : it's not smooth at all on tab switching, I feel like the whole page is refreshed

/**
* Layer managing router depending on user authentication state
*/
const AppWrapperWithRedux: FunctionComponent = () => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const AppWrapperWithRedux: FunctionComponent = () => (
const AppWrapperWithRouter: FunctionComponent = () => (

Or something like that...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the point will all these wrappers, they are really necessary ?

Copy link
Collaborator Author

@Tristan-WorkGH Tristan-WorkGH Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

That was to keep the idea of a component by provider (redex, intl, style, redux) like started gridapp-template.

/**
* Layer injecting Redux store in context
*/
const AppWrapper: FunctionComponent = () => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const AppWrapper: FunctionComponent = () => (
const AppWrapperWithRedux: FunctionComponent = () => (

connections = 'connections',
}

export function appRoutes(): RouteObject[] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a function ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a structure config with components having dependencies in React context, so I can't per-iniitialize it in a constant outside.

@antoinebhs
Copy link

antoinebhs commented Feb 21, 2024

There is a glitch in the display when various users are added:
Peek 21-02-2024 14-50

It also looks like the table can grow vertically while we would probably expect a slider inside the table with a fixed height?:
image

@Tristan-WorkGH Tristan-WorkGH mentioned this pull request Mar 8, 2024
7 tasks
@Tristan-WorkGH Tristan-WorkGH merged commit 607111d into main Mar 8, 2024
@Tristan-WorkGH Tristan-WorkGH deleted the add_users branch March 8, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants