-
Notifications
You must be signed in to change notification settings - Fork 0
Add users and connections management #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Now tabs update correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The button Add user is not shown in the interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many commented code / TODO
Problem with routing : it's not smooth at all on tab switching, I feel like the whole page is refreshed
/** | ||
* Layer managing router depending on user authentication state | ||
*/ | ||
const AppWrapperWithRedux: FunctionComponent = () => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const AppWrapperWithRedux: FunctionComponent = () => ( | |
const AppWrapperWithRouter: FunctionComponent = () => ( |
Or something like that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the point will all these wrappers, they are really necessary ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No
That was to keep the idea of a component by provider (redex, intl, style, redux) like started gridapp-template.
src/components/app-wrapper.tsx
Outdated
/** | ||
* Layer injecting Redux store in context | ||
*/ | ||
const AppWrapper: FunctionComponent = () => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const AppWrapper: FunctionComponent = () => ( | |
const AppWrapperWithRedux: FunctionComponent = () => ( |
connections = 'connections', | ||
} | ||
|
||
export function appRoutes(): RouteObject[] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why a function ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a structure config with components having dependencies in React context, so I can't per-iniitialize it in a constant outside.
977f739
to
6625f0f
Compare
6625f0f
to
3eaa8ca
Compare
ab9a747
to
74cc8d5
Compare
a769310
to
d7ec87c
Compare
d7ec87c
to
22b8e1a
Compare
Initial version of gridadmin with users management and connections view.