Remove mock auth & split REST APIs #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMaskedTurtle
requested changes
Feb 5, 2024
TheMaskedTurtle
approved these changes
Feb 5, 2024
klesaulnier
approved these changes
Feb 5, 2024
.env
Outdated
Comment on lines
1
to
9
| EXTEND_ESLINT=true | ||
|
|
||
| REACT_APP_API_GATEWAY=api/gateway | ||
| REACT_APP_WS_GATEWAY=ws/gateway | ||
| REACT_APP_API_GATEWAY=/api/gateway | ||
| REACT_APP_WS_GATEWAY=/ws/gateway | ||
|
|
||
| EXTEND_ESLINT=true | ||
| REACT_APP_SRV_STUDY_URI=study | ||
| REACT_APP_SRV_CONFIG_URI=config | ||
| REACT_APP_SRV_CONFIG_NOTIF_URI=config-notification | ||
| REACT_APP_SRV_USER_ADMIN_URI=user-admin |
There was a problem hiding this comment.
it's a bit confusing to have something that different from gridstudy-app
- REACT_APP_API_GATEWAY=/api/gateway : there is not any "/" in front of the URL in gridstudy
- server URI are defined in service files directly
There was a problem hiding this comment.
- it's a fix : we define all URLs in services like
STUDY_URL = ``${process.env.REACT_APP_API_GATEWAY}/${process.env.REACT_APP_SRV_STUDY_URI}/v1``;, so we already have a slash in url, no use to have double
it don't pose a problem in gridstudy for example because consecutive slashes are treated like one only for URL - it's to offer more configuration of the application without having to edit all files
we can configure the gateway path, so why not also the service name/path ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GridAdmin need to use multiples servers while being authenticate, so mock auth isn't usable as is.
Also split rest API in modules for better readability.