Fix line name modification + rework LineModification dialog #3260
Conversation
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
src/components/dialogs/network-modifications/line/modification/line-modification-dialog.tsx
Outdated
Show resolved
Hide resolved
src/components/dialogs/network-modifications/line/modification/line-modification-type.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
There was a problem hiding this comment.
I updated the naming as requested.
But you are talking about other extra things (uuid, and some null and udnefined behavior) while also asking for less changes in the discussion. Can you say clearly if you want me to change those things or only change the bare minimum for the bug correction ? (and let the other errors here)
Maybe I should also remove the renaming BTW, because it is not needed either ?
Simplified version with only the bug correction : #3279
(typescript complains like expected)
src/components/dialogs/network-modifications/line/modification/line-modification-dialog.tsx
Outdated
Show resolved
Hide resolved
src/components/dialogs/network-modifications/line/modification/line-modification-type.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
| modificationUuid: editData?.uuid ?? '', | ||
| lineId: selectedId, | ||
| lineName: sanitizeString(line[EQUIPMENT_NAME]?.value) ?? '', | ||
| equipmentName: toModificationOperation(sanitizeString(line[EQUIPMENT_NAME]) ?? ''), |
There was a problem hiding this comment.
| equipmentName: toModificationOperation(sanitizeString(line[EQUIPMENT_NAME]) ?? ''), | |
| lineName: toModificationOperation(sanitizeString(line[EQUIPMENT_NAME]) ?? ''), |
To be more homogeneous with the other modifications ?
There was a problem hiding this comment.
OK done. But I had to put it back into LineModificationInfos. And I saw it only in LineCreationInfo : 1289927
| modificationUuid, | ||
| lineId, | ||
| lineName, | ||
| equipmentName, |
|
|
||
| export interface LineModificationEditData { | ||
| uuid?: string; | ||
| export interface LineModificationDialogForm { |
There was a problem hiding this comment.
| export interface LineModificationDialogForm { | |
| export interface LineModificationFormInfos { |
This nomenclature looks more used
|
Tests ok |
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
|
Mathieu-Deharbe
changed the title
Mathieu-Deharbe
deleted the
more-rigorous-LineModificationForm-typing
branch
No description provided.