Skip to content

Conversation

etiennehomer
Copy link
Contributor

@etiennehomer etiennehomer commented Sep 12, 2025

Use the naming strategy given as parameter for CreateCouplingDevice, CreateVoltageLevelSection and CreateVoltageLevelTopology.

Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
@etiennehomer etiennehomer changed the title Modification application with naming strategy [WIP] Modification application with naming strategy Sep 12, 2025
.withBusOrBusbarSectionId1(createCouplingDeviceInfos.getCouplingDeviceInfos().getBusbarSectionId1())
.withBusOrBusbarSectionId2(createCouplingDeviceInfos.getCouplingDeviceInfos().getBusbarSectionId2())
.build().apply(network, false, subReportNode);
.build().apply(network, namingStrategy, false, subReportNode);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove false argument !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

…pology + tests

Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
@etiennehomer etiennehomer changed the title [WIP] Modification application with naming strategy Modification application with naming strategy Sep 15, 2025
Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
Copy link

@etiennehomer etiennehomer requested a review from ipirog September 19, 2025 06:55
@etiennehomer etiennehomer merged commit d7afbc7 into main Sep 22, 2025
4 checks passed
@etiennehomer etiennehomer deleted the apply_with_naming_strategy branch September 22, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants