Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and adapt DB model to new ReportNode API #87

Merged
merged 9 commits into from
Aug 22, 2024

Conversation

ayolab
Copy link
Contributor

@ayolab ayolab commented Aug 7, 2024

This PR takes up the work done in #81

ayolab added 6 commits August 7, 2024 16:42
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@ayolab ayolab requested a review from TheMaskedTurtle August 13, 2024 14:21
ayolab added 2 commits August 17, 2024 17:20
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@ayolab ayolab requested a review from TheMaskedTurtle August 19, 2024 07:22
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
Copy link

Copy link
Contributor

@dbraquart dbraquart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code: ok
tests: ok

@dbraquart
Copy link
Contributor

Remember before merging you have to run admin_tool / invalidate_nodes_builds.py on demo platform

@TheMaskedTurtle TheMaskedTurtle merged commit f9f10b3 into main Aug 22, 2024
3 checks passed
@TheMaskedTurtle TheMaskedTurtle deleted the ayolab/simplify-db-schema branch August 22, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants