Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update parent report severities when appending new children #89

Merged
merged 2 commits into from
Sep 9, 2024
Merged

fix: update parent report severities when appending new children #89

merged 2 commits into from
Sep 9, 2024

Conversation

TheMaskedTurtle
Copy link
Contributor

No description provided.

@TheMaskedTurtle
fix: update parent report severities when appending new children
a50ddcb 
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
dbraquart
dbraquart approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@dbraquart dbraquart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code: ok
tests: ok (this fixes the incremental report issue)

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@dbraquart dbraquart merged commit fe51313 into main Sep 9, 2024
3 checks passed
@dbraquart dbraquart deleted the fix/propagate-severity-to-parent branch September 9, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbraquart dbraquart dbraquart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheMaskedTurtle @dbraquart