Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hacks #91

Merged
merged 10 commits into from
Sep 26, 2024
Merged

Remove hacks #91

merged 10 commits into from
Sep 26, 2024

Conversation

ayolab
Copy link
Contributor

@ayolab ayolab commented Sep 6, 2024

No description provided.

@ayolab
Remove hacks
30f2662 
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@ayolab
Fix tests
41e409a 
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@ayolab
fix code smell
fa5a7cb 
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@ayolab
clean test data
54ab678 
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@dbraquart dbraquart self-requested a review September 12, 2024 16:08
dbraquart
dbraquart reviewed Sep 12, 2024
View reviewed changes
Copy link
Contributor

@dbraquart dbraquart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code: some remarks
tests : on going

src/main/java/org/gridsuite/report/server/ReportController.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/report/server/ReportService.java Show resolved Hide resolved
src/main/java/org/gridsuite/report/server/ReportController.java Outdated Show resolved Hide resolved
@ayolab ayolab changed the base branch from main to add_filter_on_message September 16, 2024 09:05
@ayolab ayolab force-pushed the ayolab/remove-hacks branch from 5a7d9c4 to 54ab678 Compare September 18, 2024 09:23
@ayolab ayolab changed the base branch from add_filter_on_message to main September 18, 2024 09:24
ayolab and others added 3 commits September 18, 2024 18:35
@ayolab
Requested changes
ec30e63 
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@ayolab
Merge branch 'main' into ayolab/remove-hacks
3050753
@ayolab
fix sonar code smells
4a1c885 
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@ayolab ayolab force-pushed the ayolab/remove-hacks branch from a678b64 to 6329012 Compare September 23, 2024 20:10
@ayolab
Requested changes
e6d1e64 
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@ayolab ayolab force-pushed the ayolab/remove-hacks branch from 6329012 to e6d1e64 Compare September 23, 2024 20:29
@ayolab ayolab force-pushed the ayolab/remove-hacks branch from ca8a9ef to 8aedd3e Compare September 25, 2024 14:44
@ayolab
Root report nodes migration
9dcaf15 
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@ayolab ayolab force-pushed the ayolab/remove-hacks branch from 8aedd3e to 9dcaf15 Compare September 25, 2024 17:08
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ayolab ayolab merged commit a36ca25 into main Sep 26, 2024
3 checks passed
@ayolab ayolab deleted the ayolab/remove-hacks branch September 26, 2024 13:07
@TheMaskedTurtle TheMaskedTurtle mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbraquart dbraquart dbraquart left review comments

@TheMaskedTurtle TheMaskedTurtle TheMaskedTurtle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayolab @TheMaskedTurtle @dbraquart