Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add filtering on msg + add endpoint to retrieve flatten msg #92

Merged
merged 15 commits into from
Sep 27, 2024
Merged

add filtering on msg + add endpoint to retrieve flatten msg #92

merged 15 commits into from
Sep 27, 2024

Conversation

AbdelHedhili
Copy link
Contributor

No description provided.

@ayolab
Remove hacks
30f2662 
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@ayolab
Fix tests
41e409a 
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@ayolab
fix code smell
fa5a7cb 
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@ayolab
clean test data
54ab678 
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@AbdelHedhili AbdelHedhili self-assigned this Sep 12, 2024
ayolab and others added 7 commits September 18, 2024 18:35
@ayolab
Requested changes
ec30e63 
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@ayolab
Merge branch 'main' into ayolab/remove-hacks
3050753
@ayolab
fix sonar code smells
4a1c885 
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@ayolab
Requested changes
e6d1e64 
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@AbdelHedhili
add filtering on msg + add endpoint to retrieve flatten msg
f767716 
Signed-off-by: Abdelsalem <abdelsalem.hedhili@rte-france.com>
@AbdelHedhili
review fixes
9cd1adf 
Signed-off-by: Abdelsalem <abdelsalem.hedhili@rte-france.com>
@AbdelHedhili
add orderByNanos and change update UT to test the order as well
0df4ce9 
Signed-off-by: Abdelsalem <abdelsalem.hedhili@rte-france.com>
@AbdelHedhili
remove useless code
cbe0540 
Signed-off-by: Abdelsalem <abdelsalem.hedhili@rte-france.com>
@AbdelHedhili
minor fix in case of null parentId
21e1f6a 
Signed-off-by: Abdelsalem <abdelsalem.hedhili@rte-france.com>
@AbdelHedhili
sort at the end
1ce9647 
Signed-off-by: Abdelsalem <abdelsalem.hedhili@rte-france.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ayolab ayolab self-requested a review September 27, 2024 08:13
TheMaskedTurtle
TheMaskedTurtle approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@TheMaskedTurtle TheMaskedTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one remaining comment from previous reviews but ok if you don't like it :)

@AbdelHedhili AbdelHedhili merged commit 6ca57d9 into main Sep 27, 2024
3 checks passed
@AbdelHedhili AbdelHedhili deleted the add_filter_on_message branch September 27, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheMaskedTurtle TheMaskedTurtle TheMaskedTurtle approved these changes

@ayolab ayolab Awaiting requested review from ayolab

Assignees

@AbdelHedhili AbdelHedhili

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AbdelHedhili @TheMaskedTurtle @ayolab