-
Notifications
You must be signed in to change notification settings - Fork 0
Add limit reductions to security analysis #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3af15d7
to
e10e71b
Compare
SlimaneAmar
requested changes
Jul 3, 2024
src/main/java/org/gridsuite/securityanalysis/server/entities/LimitReductionEntity.java
Outdated
Show resolved
Hide resolved
...in/java/org/gridsuite/securityanalysis/server/entities/SecurityAnalysisParametersEntity.java
Show resolved
Hide resolved
...in/java/org/gridsuite/securityanalysis/server/entities/SecurityAnalysisParametersEntity.java
Outdated
Show resolved
Hide resolved
...in/java/org/gridsuite/securityanalysis/server/entities/SecurityAnalysisParametersEntity.java
Outdated
Show resolved
Hide resolved
...in/java/org/gridsuite/securityanalysis/server/service/SecurityAnalysisParametersService.java
Outdated
Show resolved
Hide resolved
...in/java/org/gridsuite/securityanalysis/server/service/SecurityAnalysisParametersService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/securityanalysis/server/service/SecurityAnalysisResultContext.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/securityanalysis/server/service/SecurityAnalysisResultContext.java
Outdated
Show resolved
Hide resolved
...est/java/org/gridsuite/securityanalysis/server/SecurityAnalysisParametersControllerTest.java
Outdated
Show resolved
Hide resolved
SlimaneAmar
reviewed
Jul 3, 2024
src/main/java/org/gridsuite/securityanalysis/server/util/LimitReductionConfig.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Slimane AMAR <amarsli@gm0winl104.bureau.si.interne>
…-server into add-limit-reduction
antoinebhs
commented
Jul 8, 2024
src/main/java/org/gridsuite/securityanalysis/server/service/SecurityAnalysisWorkerService.java
Outdated
Show resolved
Hide resolved
…lues and remove endpoint to get limit reduction metadata Signed-off-by: Slimane AMAR <amarsli@gm0winl104.bureau.si.interne>
f5a0593
to
346d857
Compare
…curity-analysis-server into add-limit-reduction
346d857
to
b3b6b7b
Compare
…-server into add-limit-reduction
…curity-analysis-server into add-limit-reduction
…s dto Signed-off-by: Slimane AMAR <amarsli@gm0winl104.bureau.si.interne>
…-server into add-limit-reduction
a4b3ce7
to
219bd44
Compare
@SlimaneAmar I checked again after your changes and it looks good to me! I haven't tested again with gridsuite/gridstudy-app#2185 gridsuite/gridstudy-app#2184. |
SlimaneAmar
approved these changes
Aug 7, 2024
e885047
to
a87f372
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for limit reduction in security analysis. The limit reduction default values and metadata are set ine configuration to give the possibility of overriding in deployment. A limit reduction table can look like:
Tasks left