Properly handle out of voltage bus error #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David SARTORI <david.sartori_externe@rte-france.com>
klesaulnier
reviewed
Jan 17, 2024
src/main/java/org/gridsuite/shortcircuit/server/service/ShortCircuitWorkerService.java
Outdated
Show resolved
Hide resolved
etiennehomer
requested changes
Jan 17, 2024
src/main/java/org/gridsuite/shortcircuit/server/service/ShortCircuitWorkerService.java
Outdated
Show resolved
Hide resolved
added 3 commits
January 17, 2024 18:08
Signed-off-by: David SARTORI <david.sartori_externe@rte-france.com>
Signed-off-by: David SARTORI <david.sartori_externe@rte-france.com>
Signed-off-by: David SARTORI <david.sartori_externe@rte-france.com>
klesaulnier
reviewed
Jan 22, 2024
Comment on lines
140
to
154
| var network = mock(Network.class); | ||
| var context = mock(ShortCircuitRunContext.class); | ||
| var busbarSection = mock(BusbarSection.class); | ||
| var terminal = mock(Terminal.class); | ||
| var busView = mock(BusView.class); | ||
| var busId = "bus1"; | ||
|
|
||
| when(context.getBusId()).thenReturn(busId); | ||
| doReturn(busbarSection).when(network).getIdentifiable(busId); | ||
| when(busbarSection.getTerminal()).thenReturn(terminal); | ||
| when(terminal.getBusView()).thenReturn(busView); | ||
| when(busView.getBus()).thenReturn(null); | ||
|
|
||
| var exception = (ShortCircuitException) catchRuntimeException(() -> workerService.getBusFaultFromBusId(network, context)); | ||
| assertThat(exception.getType()).isEqualTo(BUS_OUT_OF_VOLTAGE); |
There was a problem hiding this comment.
@etiennehomer
I'm not sure we should use "var", what do you think ?
In such a small scope, I guess it's ok
There was a problem hiding this comment.
Yes why not in a small test method like this
Signed-off-by: David SARTORI <david.sartori_externe@rte-france.com>
etiennehomer
requested changes
Jan 22, 2024
src/test/java/org/gridsuite/shortcircuit/server/service/ShortCircuitServiceTest.java
Outdated
Show resolved
Hide resolved
added 2 commits
January 22, 2024 17:40
Signed-off-by: David SARTORI <david.sartori_externe@rte-france.com>
Signed-off-by: David SARTORI <david.sartori_externe@rte-france.com>
Signed-off-by: David SARTORI <david.sartori_externe@rte-france.com>
klesaulnier
approved these changes
Jan 24, 2024
Signed-off-by: David SARTORI <david.sartori_externe@rte-france.com>
|
etiennehomer
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.