Handle and get dynamically enum filter #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b0f841c.
…filter' into handle-and-get-dynamically-enum-filter
|
Why not have an endpoint for each calculation, passing it the type (limit-types, branch-sides...) and having it return a list of strings? This would merge the methods in the service layer |
Mathieu-Deharbe
requested changes
Apr 18, 2024
|
@Mathieu-Deharbe |
anistouri
reviewed
Apr 23, 2024
…filter' into handle-and-get-dynamically-enum-filter
src/main/java/org/gridsuite/study/server/service/LoadFlowService.java
Outdated
Show resolved
Hide resolved
Comment on lines
+425
to
+437
| // get computing status | ||
| mockMvc.perform(get("/v1/studies/{studyUuid}/nodes/{nodeUuid}/computation/result/enum-values?computingType={computingType}&enumName={enumName}", | ||
| studyNameUserIdUuid, modificationNode1Uuid, LOAD_FLOW, "computation-status")) | ||
| .andExpectAll(status().isOk(), | ||
| content().string(COMPUTING_STATUS_JSON)); | ||
|
|
||
| assertTrue(TestUtils.getRequestsDone(1, server).stream().anyMatch(r -> r.matches("/v1/results/" + LOADFLOW_RESULT_UUID + "/computation-status"))); | ||
|
|
||
| mockMvc.perform(get("/v1/studies/{studyUuid}/nodes/{nodeUuid}/computation/result/enum-values?computingType={computingType}&enumName={enumName}", | ||
| studyNameUserIdUuid, modificationNode1Uuid, LOAD_FLOW, "computation")).andReturn(); | ||
|
|
||
| assertTrue(TestUtils.getRequestsDone(1, server).stream().anyMatch(r -> r.matches("/v1/results/" + LOADFLOW_RESULT_UUID + "/computation"))); | ||
|
|
There was a problem hiding this comment.
These tests are not about limit violations. They shouldn't be in a testGetLimitViolations function.
src/test/java/org/gridsuite/study/server/SecurityAnalysisTest.java
Outdated
Show resolved
Hide resolved
|
Mathieu-Deharbe
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.