-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a warning to user or admin about possible repeat entries #124
Comments
This sounds similar/related to this issue perhaps: |
As I understand it, griffithlab/civic-server#58 only applies to new suggested revisions from edit forms, and not new evidence items from the add evidence form. I definitely think it would be helpful to add the feature described by @kkrysiak above, and have given it some thought. On the add evidence form, as soon as the form gets the gene, variant, and pubmed id, it can query the server to see if there are any matching entries, and then display them to the user as a small warning somewhere on the form - something like, "NOTE: [Existing/Pending] submissions exist for [gene][variant][evidence]. Please review the existing record here (link) to ensure that you intended submission is sufficiently unique to warrant its inclusion." |
@jmcmichael, my concern with using gene, variant and pubmed id is that a single pubmed source can provide multiple lines of different types of evidence for a given variant (diagnostic - associated with X disease; prognostic - associated with poor survival), which is why I was recommending the inclusion of evidence type. Admittedly, I don't know how often that has happened in the data we have at this point. |
I definitely like the idea of seeing a list of possibly similar items for the user to review. For multiple entries coming from the same source publication this could really help you to think about how to frame each of them (in addition to helping to avoid duplication). |
With that in mind, sticking with gene, variant and pubmed ID for a comparator is perfect. It would just need to support multiple entries in an easily understood way for the user. |
OK, I believe this is doable on the client w/o requiring anything additional on the server. I'll go ahead and put a 'high priority' label on it. |
I almost entered a repeat entry today (DNAJB1-PRKACA) because I didn't realize someone else had beaten me to it. Currently, this is an admin task to clean up such events but without looking at the entries for a given variant, this is not evident in the admin interface. If we could automatically run a check for any evidence that matches "Evidence Type," "Pubmed ID" and "Variant" I think it would be very helpful. I can see this being handled in 2 ways. 1) A very simple warning in the admin interface indicating a possible repeat entry so we can compare and handle it appropriately. 2) A warning in the user interface displaying the existing entry that may conflict and a sort of "are you sure you want to submit?" interface. Something like two buttons indicating "submit, this is a unique entry" or "nevermind, this is a repeat" so the user can decide.
The text was updated successfully, but these errors were encountered: