Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expected behavior when user submits suggested revision identical to existing suggested revision? #58

Closed
jmcmichael opened this issue May 28, 2015 · 0 comments
Assignees
Labels

Comments

@jmcmichael
Copy link
Contributor

Currently we return a 509 if a user submits an entity revision that doesn't contain any edits. In griffithlab/civic-client#88, Obi noted that he was able to submit several identical gene suggested revisions. I had expected that these would genreate 509s as well, but thinking back I don't recall if we discussed/implemented this or not.

As the revisions system is currently implemented, should these identical revisions be generating 509s and did Obi find a bug? Or is returning 509s from identical suggested something we need to discuss and add as an enhancement? (personally I think identical revisions should return a 509 or some other error).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants