add simple hs pattern #218
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a high availability (HA) setup for the application by implementing load balancing across multiple API instances. The changes introduce a Docker Compose configuration that deploys two API instances behind an nginx load balancer.
Key changes:
- Adds nginx load balancer configuration to distribute traffic between two API instances
- Creates Docker Compose setup with duplicated API services (api1, api2) and load balancer
- Updates environment configuration to use container names instead of localhost for service discovery
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| nginx/nginx.conf | Configures upstream load balancer with two API servers and proxy settings |
| nginx/Dockerfile | Creates nginx container with custom configuration |
| compose-ha.yml | Defines multi-container setup with two API instances, database, Redis, and load balancer |
| .env | Updates host references from localhost to container names for inter-service communication |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| server { | ||
| listen 80; | ||
|
|
||
| location / { | ||
| proxy_pass http://loadbalancer; | ||
| } | ||
| } |
There was a problem hiding this comment.
The nginx configuration lacks security headers and basic hardening. Consider adding security headers like X-Frame-Options, X-Content-Type-Options, and configuring proper error pages to avoid information disclosure.
Copilot uses AI. Check for mistakes.
| loadbalancer: | ||
| container_name: panettone_loadbalancer | ||
| build: ./nginx | ||
| ports: | ||
| - "8080:80" | ||
| depends_on: | ||
| - api1 | ||
| - api2 |
There was a problem hiding this comment.
The load balancer depends_on configuration only ensures containers start in order but doesn't wait for the API services to be ready. Consider adding health checks to the API services and using depends_on with condition: service_healthy to ensure the load balancer only starts when backends are actually ready to serve traffic.
Copilot uses AI. Check for mistakes.
No description provided.