-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explanation for translation entropy constants #1077
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ty Balduf <ty.balduf@schrodinger.com>
Signed-off-by: Ty Balduf <ty.balduf@schrodinger.com>
So I rewrote the translation entropy equation and it gives approximately the same result (free energy differs by ~10^-5 kcal/mol) If I work out the equivalent of magic4 and magic5, they come out to:
As best I can tell, these must have been originally been worked out with slightly different definitions of the constants. Not all the constants used in xTB correspond to their exact current value. For example in thermo, these values are defined:
@marcelmbn Not sure if this is an acceptable difference and tests should be updated or this is too large a change and we just stick with the current magic constants, just providing some documentation on how they were likely calculated. |
Thanks for the correct implementation of the constant!
Thank you in advance for your work on this project! |
@TyBalduf Just wanted to ping you again on this topic. We'd be very grateful if you find the time to update the related points in the code to the SotA standard you suggested, including the correct ab initio constants, so that we can integrate everything into the |
I've been a little preoccupied of late and won't have a chance to work on this too soon. I can probably get to it eventually, its mainly a matter of updating tests. But I'm not actively working on it so if someone else wanted to take this on, there wouldn't be conflicting work. |
Worked out the constants following the expressions for translation entropy given (among other places) here