Repository navigation
Replies: 1 comment
|
Your reading of the code is spot-on — the
Because A PR making
Opening a PR (or an issue linking |
|
Your reading of the code is spot-on — the
Because A PR making
Opening a PR (or an issue linking |
Uh oh!
There was an error while loading. Please reload this page.
Hi.
I've configured and using Sync Adapters from both Apple and Kandji/Iru since early this week, and they're really great, working fine! Awesome! Thank you for this feature!
However, now that I'm playing with EULA, I noticed when I reassign a device on Kandji the user is correctly updated in SnipeIT, but that won't trigger the EULA acceptance, even if the category requires it, and even if Suppress notifications (email, webhooks) on sync-driven assignments is unchecked.
I understand this happens because the scheduled/background sync has no
auth()->user, andAsset::checkOut()receives anulluser, thus not triggering the notification. Can I propose an amendment to make$checkedOutBynullable in the event and inCheckoutAssetNotification, make the webhook messages handle a missing admin, and drop the$admin === nullfallback in the sync code?Or was this intended this way for other purposes? thanks
All reactions